Re: [PATCH net-next] net: dsa: mv88e6xxx: missing unlock on error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: missing unlock on error path
From: Andrew Lunn <andrew@xxxxxxx>
Date: Tue, 14 Aug 2018 15:42:32 +0200
Cc: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>, Florian Fainelli <f.fainelli@xxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20180814090905.rm6i665c5utl7d32@kili.mountain>
References: <20180814090905.rm6i665c5utl7d32@kili.mountain>
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, Aug 14, 2018 at 12:09:05PM +0300, Dan Carpenter wrote:
> We added a new error path, but we need to drop the lock before we return.
> 
> Fixes: 2d2e1dd29962 ("net: dsa: mv88e6xxx: Cache the port cmode")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Signed-off-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew

References:
- [PATCH net-next] net: dsa: mv88e6xxx: missing unlock on error path
  - From: Dan Carpenter

Prev by Date: Re: [PATCH net-next] net: dsa: mv88e6xxx: bitwise vs logical bug
Next by Date: Re: [PATCH net-next] net: dsa: mv88e6xxx: bitwise vs logical bug
Previous by thread: [PATCH net-next] net: dsa: mv88e6xxx: missing unlock on error path
Next by thread: Re: [PATCH net-next] net: dsa: mv88e6xxx: missing unlock on error path
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux