On Fri, Aug 03, 2018 at 10:24:31PM +0300, Dan Carpenter wrote: > A couple of the callers assume that ib_post_send() initializes > *bad_send_wr. It doesn't look like we can rely on the ->post_send() > function to initialize it. For example in the i40iw_post_recv() > function and there are some error paths there which don't set it. I think those are bugs in the drivers, if bad_wr is provided, and post_send fails then it must be set to the wr that has a problem, left unset/uninit is incorrect. This is a high performance call path, so I'd prefer not to see unnecessary babying of drivers.. Bart? Thanks, Jason -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html