Lorenzo, Added the compilation support in the next patch submitted at : https://patchwork.kernel.org/patch/10551771/ please review. Thanks, Subrahmanya On Thu, Jul 26, 2018 at 4:26 PM, Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> wrote: > On Thu, Jul 05, 2018 at 12:45:39PM +0300, Dan Carpenter wrote: >> IB_WIN_SIZE is larger than INT_MAX so we need to cast it to u64. >> >> Fixes: 9af6bcb11e12 ("PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver") >> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> >> --- >> Untested... Possibly the problem is that there are too many multiplies >> by * 1024. >> >> diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c > > Applied to pci/mobiveil for v4.19 (it is still not fixing anything > given that the driver lacks a Kconfig and Makefile entries - that > must be fixed with urgency), thanks. > > Lorenzo > >> index 4d6c20e47bed..cf0aa7cee5b0 100644 >> --- a/drivers/pci/controller/pcie-mobiveil.c >> +++ b/drivers/pci/controller/pcie-mobiveil.c >> @@ -107,7 +107,7 @@ >> #define CFG_WINDOW_TYPE 0 >> #define IO_WINDOW_TYPE 1 >> #define MEM_WINDOW_TYPE 2 >> -#define IB_WIN_SIZE (256 * 1024 * 1024 * 1024) >> +#define IB_WIN_SIZE ((u64)256 * 1024 * 1024 * 1024) >> #define MAX_PIO_WINDOWS 8 >> >> /* Parameters for the waiting for link up routine */ -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
