On 07/17/2018 04:52 PM, Colin King wrote:
From: Colin Ian King<colin.king@xxxxxxxxxxxxx>
The rol32 call is currently rotating hash but the rol'd value is
being discarded. I believe the current code is incorrect and hash
should be assigned the rotated value returned from rol32.
Detected by CoverityScan, CID#1468411 ("Useless call")
Fixes: b5facfdba14c ("ipv6: sr: Compute flowlabel for outer IPv6 header of seg6 encap mode")
Signed-off-by: Colin Ian King<colin.king@xxxxxxxxxxxxx>
Acked-by: dlebrun@xxxxxxxxxx
Good catch, thanks !
In that case, the same issue is present in
include/net/ipv6.h:ip6_make_flowlabel().
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
