On Tue, Jul 03, 2018 at 10:34:12AM -0700, Joe Perches wrote: > On Tue, 2018-07-03 at 18:57 +0200, Walter Harms wrote: > > It is only cosmetics but even the author got lost about the loose bracket. > > I would suggest to remove all the brackets or if needed to move the [ in the > > message. We have enought memory this days. > > My suggestion would be to remove the separate dev_err > and use "Event log [" in each dev_err. > > So here's an actual suggested patch that does a few things: > > o Coalesce formats and realigns arguments > o Uses pr_fmt and dev_fmt to prefix "AMD-Vi: " to all messages > o Remove embedded "AMD-Vi: " from various formats Nice cleanup! But I got lost a bit in the patches floating around in this thread and their dependencies. Can someone sort it out and send it a new patch-set to me? Thanks, Joerg -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html