On Wed, Jul 04, 2018 at 12:48:10PM +0300, Dan Carpenter wrote: > The > should be >= here so that we don't read beyond the end of the > dma->buflist[] array. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Uh, another root-hole driver ... Applied, thanks for the patch. -Daniel > > diff --git a/drivers/gpu/drm/savage/savage_state.c b/drivers/gpu/drm/savage/savage_state.c > index 2db89bed52e8..7559a820bd43 100644 > --- a/drivers/gpu/drm/savage/savage_state.c > +++ b/drivers/gpu/drm/savage/savage_state.c > @@ -971,7 +971,7 @@ int savage_bci_cmdbuf(struct drm_device *dev, void *data, struct drm_file *file_ > LOCK_TEST_WITH_RETURN(dev, file_priv); > > if (dma && dma->buflist) { > - if (cmdbuf->dma_idx > dma->buf_count) { > + if (cmdbuf->dma_idx >= dma->buf_count) { > DRM_ERROR > ("vertex buffer index %u out of range (0-%u)\n", > cmdbuf->dma_idx, dma->buf_count - 1); > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html