The error return code PTR_ERR(pdata) is always 0 since pdata is NULL in this error handling case. Fixes: 5c1355ad87a2 ("dmaengine: fsl-edma: add ColdFire mcf5441x edma support") Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> --- drivers/dma/mcf-edma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/mcf-edma.c b/drivers/dma/mcf-edma.c index 31e5317..787b7b6 100644 --- a/drivers/dma/mcf-edma.c +++ b/drivers/dma/mcf-edma.c @@ -175,7 +175,7 @@ static int mcf_edma_probe(struct platform_device *pdev) pdata = dev_get_platdata(&pdev->dev); if (!pdata) - return PTR_ERR(pdata); + return -EINVAL; chans = pdata->dma_channels; len = sizeof(*mcf_edma) + sizeof(*mcf_chan) * chans; -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html