On Tue, 2018-07-03 at 07:56 -0500, Gary R Hook wrote: > On 07/03/2018 05:07 AM, Joe Perches wrote: > > On Tue, 2018-07-03 at 07:40 +0100, Colin King wrote: > > > Currently tag is being assigned but not used, it is missing from > > > the dev_err message, so add it in. > > > > > > Cleans up clang warning: > > > warning: variable 'tag' set but not used [-Wunused-but-set-variable] > > > > [] > > > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c > > > > [] > > > @@ -616,9 +616,9 @@ static void iommu_print_event(struct amd_iommu *iommu, void *__evt) > > > pasid = ((event[0] >> 16) & 0xFFFF) > > > | ((event[1] << 6) & 0xF0000); > > > tag = event[1] & 0x03FF; > > > - dev_err(dev, "INVALID_PPR_REQUEST device=%02x:%02x.%x pasid=0x%05x address=0x%016llx flags=0x%04x]\n", > > > + dev_err(dev, "INVALID_PPR_REQUEST device=%02x:%02x.%x pasid=0x%05x address=0x%016llx flags=0x%04x tag=0x%03x]\n", > > > PCI_BUS_NUM(devid), PCI_SLOT(devid), PCI_FUNC(devid), > > > - pasid, address, flags); > > > + pasid, address, flags, tag); > > > > Seems to have a superfluous ] that should be removed. > > Yeah, I pretty much messed up all of the log messages in that function. > My apologies. I'll create a patch for that problem; it shouldn't be > fixed here. I also wonder why event is declared volatile and then dereferenced with [<constant>] multiple times. Maybe each array dereference should be stored as a local variable instead. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
