Re: [PATCH] kvmclock: remove redundant variable 'size'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 02/07/18 08:06, Colin King wrote:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Variable size is being assigned but is never used hence it is redundant
and can be removed.

Cleans up clang warning:
warning: variable ‘size’ set but not used [-Wunused-but-set-variable]


Is it worth adding

Fixes: cc1e24fdb064 ("x86/vdso: Remove pvclock fixmap machinery")

Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

either way

Reviewed-by: Liam Merwick <liam.merwick@xxxxxxxxxx>

---
  arch/x86/kernel/kvmclock.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
index bf8d1eb7fca3..45c22ce941c1 100644
--- a/arch/x86/kernel/kvmclock.c
+++ b/arch/x86/kernel/kvmclock.c
@@ -354,13 +354,10 @@ int __init kvm_setup_vsyscall_timeinfo(void)
  	int cpu;
  	u8 flags;
  	struct pvclock_vcpu_time_info *vcpu_time;
-	unsigned int size;
if (!hv_clock)
  		return 0;
- size = PAGE_ALIGN(sizeof(struct pvclock_vsyscall_time_info)*NR_CPUS);
-
  	cpu = get_cpu();
vcpu_time = &hv_clock[cpu].pvti;

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux