We accidentally return 1 instead instead the negative error codes.
Fixes: df44831ee2dd ("USB host: Add USB ehci support for nuvoton npcm7xx platform")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
The original patch used the "USB host:" prefix. This is driver code and
not generic USB host code so that's not the right thing. This is a very
common mistake in new drivers... It's a pain because then it's up to me
to guess what people want. Some subsystems have their own specific
rules and I can't remember them all so I sometimes get it wrong.
I probably guessed the obvious prefix this time so that's fine...
diff --git a/drivers/usb/host/ehci-npcm7xx.c b/drivers/usb/host/ehci-npcm7xx.c
index c80a8792d3b0..adaf8fb4b459 100644
--- a/drivers/usb/host/ehci-npcm7xx.c
+++ b/drivers/usb/host/ehci-npcm7xx.c
@@ -74,14 +74,14 @@ static int npcm7xx_ehci_hcd_drv_probe(struct platform_device *pdev)
if (IS_ERR(gcr_regmap)) {
dev_err(&pdev->dev, "%s: failed to find nuvoton,npcm750-gcr\n",
__func__);
- return IS_ERR(gcr_regmap);
+ return PTR_ERR(gcr_regmap);
}
rst_regmap = syscon_regmap_lookup_by_compatible("nuvoton,npcm750-rst");
if (IS_ERR(rst_regmap)) {
dev_err(&pdev->dev, "%s: failed to find nuvoton,npcm750-rst\n",
__func__);
- return IS_ERR(rst_regmap);
+ return PTR_ERR(rst_regmap);
}
/********* phy init ******/
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
