Re: [PATCH] typec: tcpm: Fix a msecs vs jiffies bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 7, 2018 at 6:17 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> The tcpm_set_state() function take msecs not jiffies.
>

Nice catch.

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> Fixes: f0690a25a140 ("staging: typec: USB Type-C Port Manager (tcpm)")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
> index 8a201dd53d36..0dfd755020f4 100644
> --- a/drivers/usb/typec/tcpm.c
> +++ b/drivers/usb/typec/tcpm.c
> @@ -3043,7 +3043,8 @@ static void run_state_machine(struct tcpm_port *port)
>                     tcpm_port_is_sink(port) &&
>                     time_is_after_jiffies(port->delayed_runtime)) {
>                         tcpm_set_state(port, SNK_DISCOVERY,
> -                                      port->delayed_runtime - jiffies);
> +                                      jiffies_to_msecs(port->delayed_runtime -
> +                                                       jiffies));
>                         break;
>                 }
>                 tcpm_set_state(port, unattached_state(port), 0);
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux