On Thu, Jun 7, 2018 at 9:22 AM, Lyude Paul <lyude@xxxxxxxxxx> wrote:
> Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>
>
> On Thu, 2018-06-07 at 01:48 +0000, Wei Yongjun wrote:
>> The error return code PTR_ERR(data->irqdomain) is always 0 since
>> data->irqdomain is equal to NULL in this error handling case.
>>
>> Fixes: 24d28e4f1271 ("Input: synaptics-rmi4 - convert irq distribution to
>> irq_domain")
>> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>> ---
>> drivers/input/rmi4/rmi_driver.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/input/rmi4/rmi_driver.c
>> b/drivers/input/rmi4/rmi_driver.c
>> index 2fb0ae0..cb6d983 100644
>> --- a/drivers/input/rmi4/rmi_driver.c
>> +++ b/drivers/input/rmi4/rmi_driver.c
>> @@ -1043,7 +1043,7 @@ int rmi_probe_interrupts(struct rmi_driver_data *data)
>> data);
>> if (!data->irqdomain) {
>> dev_err(&rmi_dev->dev, "Failed to create IRQ domain\n");
>> - return PTR_ERR(data->irqdomain);
>> + return -ENOMEM;
>> }
>>
>> data->irq_count = irq_count;
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-input" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> Cheers,
> Lyude Paul
Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
