From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Date: Thu, 31 May 2018 15:01:25 +0300 > @@ -380,7 +380,8 @@ static rx_handler_result_t net_failover_handle_frame(struct sk_buff **pskb) > > static void net_failover_compute_features(struct net_device *dev) > { > - u32 vlan_features = FAILOVER_VLAN_FEATURES & NETIF_F_ALL_FOR_ALL; > + netdev_features_t vlan_features = FAILOVER_VLAN_FEATURES | > + NETIF_F_ALL_FOR_ALL; The type does need to be corrected to netdev_features_t, but the logical operation is correct. It's a policy operation that was simply by-hand propagated all over the place where these kinds of calculations are performed. So vlan_features is starting with a value of 0 intentionally. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html