Hi Dan, On 05/18/2018 09:58 AM, Dan Carpenter wrote: > We accidentally free "e" twice. > > Fixes: 81110384441a ("bpf: sockmap, add hash map support") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/kernel/bpf/sockmap.c b/kernel/bpf/sockmap.c > index c6de1393df63..216d5c9b0eb3 100644 > --- a/kernel/bpf/sockmap.c > +++ b/kernel/bpf/sockmap.c > @@ -1833,7 +1833,6 @@ static int __sock_map_ctx_update_elem(struct bpf_map *map, > if (tx_msg) > bpf_prog_put(tx_msg); > write_unlock_bh(&sock->sk_callback_lock); > - kfree(e); > return err; > } Thanks for the two fixes, appreciate it! There were two similar ones that fix the same issues which were already applied yesterday to bpf-next: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=0e4364560361d57e8cd873a8990327f3471d7d8a https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=a78622932c27e8ec33e5ba180f3d2e87fb806b28 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html