* Tony Lindgren <tony@xxxxxxxxxxx> [180517 07:03]:
> * Dan Carpenter <dan.carpenter@xxxxxxxxxx> [180517 12:47]:
> > 143 ddata->clocks[index] = devm_clk_get(ddata->dev, name);
> > 144 if (IS_ERR(ddata->clocks[index])) {
> > 145 if (PTR_ERR(ddata->clocks[index]) == -ENOENT)
> > 146 return 0;
> > 147
> > 148 dev_err(ddata->dev, "clock get error for %s: %li\n",
> > 149 name, PTR_ERR(ddata->clocks[index]));
> > 150
> >
> > Should we set ddata->clocks[index] = NULL on this path?
>
> Maybe yeah. At least if clk_prepare later on fails we want to set it to
> either to NULL or error to prevent clk_enable() being called on a failed
> clock.
Looks like no need, we're bailing out of the probe anyways on errors.
And the clock_enable/disable calls do IS_ERR_OR_NULL(ddata->clocks[i]).
I'll send out the fix shortly.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
