Hi Dan,
On 16 May 2018 at 16:48, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> We recently cleaned this code up but we need to update the error
> handling as well. The devm_ioremap_resource() returns error pointers on
> error, never NULL.
>
> Fixes: e7f063ae1a31 ("dmaengine: sprd: Use devm_ioremap_resource() to map memory")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Thanks.
Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
>
> diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
> index e715d07aa632..36df3b096bbc 100644
> --- a/drivers/dma/sprd-dma.c
> +++ b/drivers/dma/sprd-dma.c
> @@ -808,8 +808,8 @@ static int sprd_dma_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> sdev->glb_base = devm_ioremap_resource(&pdev->dev, res);
> - if (!sdev->glb_base)
> - return -ENOMEM;
> + if (IS_ERR(sdev->glb_base))
> + return PTR_ERR(sdev->glb_base);
>
> dma_cap_set(DMA_MEMCPY, sdev->dma_dev.cap_mask);
> sdev->total_chns = chn_count;
--
Baolin.wang
Best Regards
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
