From: Colin Ian King <colin.king@xxxxxxxxxxxxx> There is an earlier check and return if tmp_oh is null, hence the finaly check to see if it is not null is redundant and can be replaced with return 1 instead. Detected by CoverityScan, CIK#1468855 ("Logically dead code") Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> --- fs/ocfs2/dlmglue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index e0a1574314e1..c34fd27a41f3 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c @@ -2695,7 +2695,7 @@ int ocfs2_inode_lock_tracker(struct inode *inode, return status; } } - return tmp_oh ? 1 : 0; + return 1; } void ocfs2_inode_unlock_tracker(struct inode *inode, -- 2.17.0 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html