Re: [Intel-gfx] [PATCH] drm/i915/dp: silence a static checker warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Rodrigo Vivi (2018-05-03 17:40:00)
> On Thu, May 03, 2018 at 01:53:22PM +0300, Dan Carpenter wrote:
> > Smatch warns that "n_entries" isn't always set.  It would trigger a
> > some WARN_ON()s on that path so presumably it can't happen but it's
> > simple enough to initialize it to zero just to silence the warning.
> 
> I usually would just ask if it would be possible to dispositioning
> as false positive or intentional on the tool, but it looks better
> indeed...

It doesn't appear to be a false positive.

intel_ddi_dp_voltage_max
 -> icl_get_combo_buf_trans()
 	default:
		MISSING_CASE();
		return NULL; /* *n_entries unset */

With

@@ -888,6 +888,7 @@ icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, enum port port,
                        *n_entries = ARRAY_SIZE(icl_combo_phy_ddi_translations_edp_1_05V);
                        return icl_combo_phy_ddi_translations_edp_1_05V;
                default:
+                       *n_entries = 0;
                        MISSING_CASE(voltage);
                        return NULL;
                }
@@ -903,6 +904,7 @@ icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, enum port port,
                        *n_entries = ARRAY_SIZE(icl_combo_phy_ddi_translations_dp_hdmi_1_05V);
                        return icl_combo_phy_ddi_translations_dp_hdmi_1_05V;
                default:
+                       *n_entries = 0;
                        MISSING_CASE(voltage);
                        return NULL;
                }

smatch is reassured that all paths then initialise n_entries.
-Chris
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux