On 2018-05-02 10:43 AM, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The declaration of pointer amdgpu_crtc has a redundant assignment to > amdgpu_crtc. Clean this up by removing it. > > Detected by CoverityScan, CID#1460299 ("Evaluation order violation") > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> Looks like i goofed. Thanks for fixing this. Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx> Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index 1dd1142246c2..2beb8821e19e 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -3773,7 +3773,7 @@ static void remove_stream(struct amdgpu_device *adev, > static int get_cursor_position(struct drm_plane *plane, struct drm_crtc *crtc, > struct dc_cursor_position *position) > { > - struct amdgpu_crtc *amdgpu_crtc = amdgpu_crtc = to_amdgpu_crtc(crtc); > + struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc); > int x, y; > int xorigin = 0, yorigin = 0; > > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html