Re: [bug report] tracing: Rewrite filter logic to be simpler and faster

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 27, 2018 at 09:59:16AM -0400, Steven Rostedt wrote:
> On Tue, 27 Mar 2018 10:30:36 +0300
> Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> 
> > Hello Steven Rostedt (VMware),
> > 
> > The patch 80765597bc58: "tracing: Rewrite filter logic to be simpler
> > and faster" from Mar 9, 2018, leads to the following static checker
> > warning:
> > 
> >     kernel/trace/trace_events_filter.c:1794 apply_event_filter()
> >     error: uninitialized symbol 'filter'.
> > 
> >     kernel/trace/trace_events_filter.c:2052 ftrace_profile_set_filter()
> >     error: uninitialized symbol 'filter'.
> > 
> > kernel/trace/trace_events_filter.c
> >   1686  /**
> >   1687   * create_filter - create a filter for a trace_event_call
> >   1688   * @call: trace_event_call to create a filter for
> >   1689   * @filter_str: filter string
> >   1690   * @set_str: remember @filter_str and enable detailed error in filter
> >   1691   * @filterp: out param for created filter (always updated on return)
> >             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > filterp is supposed to get updated.
> 
> Wow, your static analyzer reads comments?
>

At first I complained to Tejun by mistake and he was like, "read the
comments"...

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux