Acked-by: Jon Maloy <jon.maloy@xxxxxxxxxxxx> Thanks ///jon > -----Original Message----- > From: Wei Yongjun [mailto:weiyongjun1@xxxxxxxxxx] > Sent: Monday, March 26, 2018 10:33 > To: Jon Maloy <jon.maloy@xxxxxxxxxxxx>; Ying Xue > <ying.xue@xxxxxxxxxxxxx> > Cc: Wei Yongjun <weiyongjun1@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; > tipc-discussion@xxxxxxxxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: [PATCH net-next] tipc: tipc_node_create() can be static > > Fixes the following sparse warning: > > net/tipc/node.c:336:18: warning: > symbol 'tipc_node_create' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > --- > net/tipc/node.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/tipc/node.c b/net/tipc/node.c index 4a95c8c..4fb4327 100644 > --- a/net/tipc/node.c > +++ b/net/tipc/node.c > @@ -333,8 +333,8 @@ static void tipc_node_write_unlock(struct tipc_node > *n) > } > } > > -struct tipc_node *tipc_node_create(struct net *net, u32 addr, > - u8 *peer_id, u16 capabilities) > +static struct tipc_node *tipc_node_create(struct net *net, u32 addr, > + u8 *peer_id, u16 capabilities) > { > struct tipc_net *tn = net_generic(net, tipc_net_id); > struct tipc_node *n, *temp_node; -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html