>> @@ -6501,14 +6501,16 @@ static int hpsa_big_passthru_ioctl(struct ctlr_info
>> *h, void __user *argp)
>> cleanup0:
>> cmd_free(h, c);
>> cleanup1:
>> - if (buff) {
>> + {
>> int i;
>>
>> for (i = 0; i < sg_used; i++)
>> kfree(buff[i]);
>> kfree(buff);
>> }
>
> Thanks for looking at the hpsa driver.
>
> This HUNK ends up with an unnamed block.
Which identifier would you like to use there?
> I would prefer to not have it structured like this.
Would you like to show a source code layout alternative?
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
