Re: [bug report] tracing: Factorize filter creation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hm...  No.  I get a second warning:

kernel/trace/trace_events_filter.c:2052 ftrace_profile_set_filter()
error: uninitialized symbol 'filter'.

kernel/trace/trace_events_filter.c
  2036  
  2037          err = -EEXIST;
  2038          if (event->filter)
  2039                  goto out_unlock;
  2040  
  2041          err = create_filter(call, filter_str, false, &filter);
  2042          if (err)
  2043                  goto free_filter;
                             ^^^^^^^^^^^
filter is uninitialized.  What are we supposed to be freeing?

  2044  
  2045          if (ftrace_event_is_function(call))
  2046                  err = ftrace_function_set_filter(event, filter);
  2047          else
  2048                  event->filter = filter;
  2049  
  2050  free_filter:
  2051          if (err || ftrace_event_is_function(call))
  2052                  __free_filter(filter);
  2053  
  2054  out_unlock:
  2055          mutex_unlock(&event_mutex);
  2056  
  2057          return err;
  2058  }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux