On Thu, 2018-03-15 at 14:57 +0300, Dan Carpenter wrote: > On Wed, Mar 14, 2018 at 06:22:07PM -0300, Thiago Jung Bauermann wrote: > > > > SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> writes: > > > > > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > > > Date: Sun, 11 Mar 2018 09:03:42 +0100 > > > > > > Add a jump target so that a bit of exception handling can be better reused > > > at the end of this function. > > > > > > This issue was detected by using the Coccinelle software. > > > > > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > > > --- > > > arch/powerpc/kernel/machine_kexec_file_64.c | 28 ++++++++++++---------------- > > > 1 file changed, 12 insertions(+), 16 deletions(-) > > > > I liked it. Thanks! > > > > Reviewed-by: Thiago Jung Bauermann <bauerman@xxxxxxxxxxxxxxxxxx> > > > > You know that compilers already re-use string constants so this doesn't > actually save memory? And modern compilers create their own jump labels so this doesn't change object code either? -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
