Am 15.03.2018 10:03, schrieb Dan Carpenter:
> Hello Andi Kleen,
>
> The patch 294fe0f52a44: "perf/x86/intel: Add INST_RETIRED.ALL
> workarounds" from Feb 17, 2015, leads to the following static checker
> warning:
>
> arch/x86/events/intel/core.c:3213 bdw_limit_period()
> warn: was expecting a 64 bit value instead of '63'
>
> arch/x86/events/intel/core.c
> 3207 static u64 bdw_limit_period(struct perf_event *event, u64 left)
> ^^^^^^^^
> 3208 {
> 3209 if ((event->hw.config & INTEL_ARCH_EVENT_MASK) ==
> 3210 X86_CONFIG(.event=0xc0, .umask=0x01)) {
> 3211 if (left < 128)
> 3212 left = 128;
> 3213 left &= ~0x3fu;
> ^^^^^^^^^^^^^^
> You're clearing the high 32 bits as well as the low 6. It should be
> ~0x3full.
please use 0x3fULL
i tend to read 0x3full as 0x3"full" i guess others will have the same problem
and it is common practise to use uppercase characters.
just my 2 cents,
re
wh
>
> 3214 }
> 3215 return left;
> 3216 }
>
> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
