Re: [PATCH v2 14/17 4/4] mfd: tps65910: Move an assignment in tps65910_sleepinit()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 09 Mar 2018, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Fri, 9 Mar 2018 09:19:42 +0100
> 
> Move the assignment for the local variable "dev" so that its setting
> will be performed after a configuration check by this function.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> 
> v2:
> Lee Jones requested a resend for this patch. The change was rebased
> on source files from Linux next-20180308.

Thanks.

What happened here: [PATCH v2 14/17 4/4]

How have you managed to insert 4 patches into the x/17 thread?

It shouldn't matter for reviewing purposes.  It just looks really
odd.

>  drivers/mfd/tps65910.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index 7e7d3d1642c6..bf16cbe6fd88 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -315,11 +315,11 @@ static int tps65910_sleepinit(struct tps65910 *tps65910,
>  	struct device *dev;
>  	int ret;
>  
> -	dev = tps65910->dev;
> -
>  	if (!pmic_pdata->en_dev_slp)
>  		return 0;
>  
> +	dev = tps65910->dev;
> +
>  	/* enabling SLEEP device state */
>  	ret = tps65910_reg_set_bits(tps65910, TPS65910_DEVCTRL,
>  				DEVCTRL_DEV_SLP_MASK);

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux