Re: [PATCH] ipmi: missing error code in try_smi_init()

[Corey Minyard <minyard@xxxxxxx>]

On 03/06/2018 03:58 AM, Dan Carpenter wrote:
> If platform_device_alloc() then we should return -ENOMEM instead of
> returning success.

Thanks, queued for next release.

-corey

> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index f2a294f78892..ff870aa91cfe 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2071,6 +2071,7 @@ static int try_smi_init(struct smi_info *new_smi)
>   						      new_smi->intf_num);
>   		if (!new_smi->pdev) {
>   			pr_err(PFX "Unable to allocate platform device\n");
> +			rv = -ENOMEM;
>   			goto out_err;
>   		}
>   		new_smi->io.dev = &new_smi->pdev->dev;


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html