On Wed, Feb 21, 2018 at 11:01:50PM +0200, Daniel Baluta wrote: > On Wed, Feb 21, 2018 at 9:28 PM, Rodrigo Siqueira > <rodrigosiqueiramelo@xxxxxxxxx> wrote: > > This patch fixes the checkpatch.pl warning: > > > > drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions > > 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. > > > ... Why this "..." :)? > > Commit subject could be done better. It is pretty obvious from the code that > we change S_IWUSR with 0200. > > Better message: > > iio:dummy: Fix poke_evN file permissions Please stop telling people to say "Fix" when it's not a bug fix... Also who cares? The commit message is perfectly clear. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
