Re: efi/apple-properties: Checking error handling in unmarshal_devices()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> While the allocator does print an error when allocations fail,
> it may not be immediately apparent to the user what the
> *consequences* are.  In this case, the consequence is that the
> device properties will not be available for consumption by
> drivers and they may fail to probe or behave in entirely
> unexpected ways.

Would it make sense to indicate such a questionable software situation
be any return code?


> Hence I deliberately printed an error message here so that the user
> can make the connection between erratic behavior of drivers later on
> and the memory allocation error here.

Do you find this terse message really sufficient?

Can the mentioned properties be required for the desired system configuration?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux