Hi Dan, On 01/23/2018 12:33 AM, Dan Carpenter wrote: > @@ -43,7 +43,7 @@ void ps3_sys_manager_register_ops(const struct ps3_sys_manager_ops *ops) > { > BUG_ON(!ops); > BUG_ON(!ops->dev); > - ps3_sys_manager_ops = ops ? *ops : ps3_sys_manager_ops; > + ps3_sys_manager_ops = *ops; This seems to be a left over from when I was adding the modular system-manager support. It doesn't really make sense if you look at how the ps3_sys_manager_ops variable is used. I added your patch to my ps3-queue branch. Thanks for the contribution. -Geoff -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html