On 18.1.2018 11:28, Dan Carpenter wrote: > We accidentally used a logical AND instead of a bitwise AND here. > > Fixes: cee8113a295a ("soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/soc/xilinx/xlnx_vcu.c b/drivers/soc/xilinx/xlnx_vcu.c > index c1d6f1b190b6..a840c0272135 100644 > --- a/drivers/soc/xilinx/xlnx_vcu.c > +++ b/drivers/soc/xilinx/xlnx_vcu.c > @@ -334,7 +334,7 @@ static int xvcu_set_vcu_pll_info(struct xvcu_device *xvcu) > */ > vcu_pll_ctrl = xvcu_read(xvcu->vcu_slcr_ba, VCU_PLL_CTRL); > clkoutdiv = vcu_pll_ctrl >> VCU_PLL_CTRL_CLKOUTDIV_SHIFT; > - clkoutdiv = clkoutdiv && VCU_PLL_CTRL_CLKOUTDIV_MASK; > + clkoutdiv = clkoutdiv & VCU_PLL_CTRL_CLKOUTDIV_MASK; > if (clkoutdiv != 1) { > dev_err(xvcu->dev, "clkoutdiv value is invalid\n"); > return -EINVAL; > Already fixed by https://www.spinics.net/lists/arm-kernel/msg628989.html Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html