Re: [PATCH] platform/x86: dell-smbios: Fix error handling in build_tokens_sysfs()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 18, 2018 at 11:50:30AM +0100, walter harms wrote:
> > @@ -523,7 +523,7 @@ static int build_tokens_sysfs(struct platform_device *dev)
> >  	return 0;
> >  
> >  out_unwind_strings:
> > -	for (i = i-1; i > 0; i--) {
> > +	for (i = i-1; i >= 0; i--) {
> >  		kfree(token_location_attrs[i].attr.name);
> >  		kfree(token_value_attrs[i].attr.name);
> >  	}
> 
> would you mind to reverse order here ?
> you know programmers are terrible at couting backwards.

I prefer to always unwind in reverse order so I'd prefer to leave it
as-is.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux