Chris Packham <Chris.Packham@xxxxxxxxxxxxxxxxxxx> writes: > On 14/01/18 06:17, Christophe JAILLET wrote: >> Le 13/01/2018 à 15:22, Borislav Petkov a écrit : >>> + Chris Packham who's been fixing some stuff in here too. >>> >>> On Sat, Jan 13, 2018 at 08:28:21AM +0100, Christophe JAILLET wrote: >>>> Reorder the error handling code in order to release the resources in >>>> reverse order than allocation. >>>> >>>> Introduce a new 'release_group' label in the error handling path and use >>>> it to void some code duplication. >>>> >>>> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> >>>> --- >>>> drivers/edac/mv64x60_edac.c | 7 ++++--- >>>> 1 file changed, 4 insertions(+), 3 deletions(-) ... >>>> >>>> -- >>> Thanks, looks good. But looking at this driver, mv64x60_mc_err_probe() >>> and mv64x60_sram_err_probe() have the same problem too. Can you address them >>> with your patch too pls? >> Will do. mv64x60_pci_err_probe() also needs some tweaks. >> >>> Also, if you feel like fixing more stuff in this driver, it doesn't use >>> the edac_printk() infrastructure but naked printk() calls. It could be >>> converted to it. >> I will only propose to remove a useless message and improve another one, >> but won't convert the whole driver, sorry. >> > > I take this you mean you have a system with a mv64x60 SoC? You might > want to make yourself known to the linuxppc-dev list. A while back the > prospects of dropping CONFIG_MV64X60 was raised[1]. I don't see anyone > actually following through on this yet but I'm not really following > linuxppc that closely. That's just because I haven't had time to do it and no one else took the hint :) So yes, Christophe if you have a machine that uses this driver please speak up, otherwise it will probably be removed. cheers -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
