> -----Original Message----- > From: Wei Yongjun [mailto:weiyongjun1@xxxxxxxxxx] > Sent: Thursday, January 11, 2018 6:27 PM > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>; Keller, Jacob E > <jacob.e.keller@xxxxxxxxx> > Cc: Wei Yongjun <weiyongjun1@xxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: [PATCH net-next] i40evf: use GFP_ATOMIC under spin lock > > A spin lock is taken here so we should use GFP_ATOMIC. > You are correct, good catch! > Fixes: 504398f0a78e ("i40evf: use spinlock to protect (mac|vlan)_filter_list") > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > --- Acked-by: Jacob Keller <jacob.e.keller@xxxxxxxxx> > drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c > b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c > index feb95b6..ca5b538 100644 > --- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c > +++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c > @@ -459,7 +459,7 @@ void i40evf_add_ether_addrs(struct i40evf_adapter > *adapter) > more = true; > } > > - veal = kzalloc(len, GFP_KERNEL); > + veal = kzalloc(len, GFP_ATOMIC); > if (!veal) { > spin_unlock_bh(&adapter->mac_vlan_list_lock); > return; > @@ -532,7 +532,7 @@ void i40evf_del_ether_addrs(struct i40evf_adapter > *adapter) > (count * sizeof(struct virtchnl_ether_addr)); > more = true; > } > - veal = kzalloc(len, GFP_KERNEL); > + veal = kzalloc(len, GFP_ATOMIC); > if (!veal) { > spin_unlock_bh(&adapter->mac_vlan_list_lock); > return; > @@ -606,7 +606,7 @@ void i40evf_add_vlans(struct i40evf_adapter *adapter) > (count * sizeof(u16)); > more = true; > } > - vvfl = kzalloc(len, GFP_KERNEL); > + vvfl = kzalloc(len, GFP_ATOMIC); > if (!vvfl) { > spin_unlock_bh(&adapter->mac_vlan_list_lock); > return; > @@ -678,7 +678,7 @@ void i40evf_del_vlans(struct i40evf_adapter *adapter) > (count * sizeof(u16)); > more = true; > } > - vvfl = kzalloc(len, GFP_KERNEL); > + vvfl = kzalloc(len, GFP_ATOMIC); > if (!vvfl) { > spin_unlock_bh(&adapter->mac_vlan_list_lock); > return; -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
