On Mon, Jan 08, 2018 at 11:14:44PM +0000, Colin King wrote: > The functions pll_event and dac_event are local to the source and do > not need to be in global scope, so make them static. This looks good to me. Thanks for catching this. You can add: Reviewed-by: Steven Eckhoff <steven.eckhoff.opensource@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html