Re: [3/3] GenWQE: Adjust 12 checks for null pointers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> I personally like the explicit compare (ptr != NULL) more than the !ptr notation.

Coding style aspects can evolve, can't they?


> When was the checkpatch.pl script modified to suggest the latter notation?

Would you like to take another look at the software update “checkpatch: add
--strict "pointer comparison to NULL" test” from 2014-12-10?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b75ac618df751b927469ddbca63cf151a62f0f9d


> Is there any advantage other than the shorter notation?

* Do you eventually care for an influence on the run time characteristics
  for the compilation of this software module?

* How do you think about to reduce the dependency on a special preprocessor symbol?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux