From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Sun, 7 Jan 2018 21:48:50 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> --- drivers/misc/apds9802als.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/apds9802als.c b/drivers/misc/apds9802als.c index fa548796c92e..acf467666737 100644 --- a/drivers/misc/apds9802als.c +++ b/drivers/misc/apds9802als.c @@ -228,9 +228,8 @@ static int apds9802als_probe(struct i2c_client *client, const struct i2c_device_id *id) { int res; - struct als_data *data; + struct als_data *data = kzalloc(sizeof(*data), GFP_KERNEL); - data = kzalloc(sizeof(struct als_data), GFP_KERNEL); if (!data) return -ENOMEM; -- 2.15.1 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html