From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 8 Jan 2018 18:01:39 +0100
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
drivers/misc/lattice-ecp3-config.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/misc/lattice-ecp3-config.c b/drivers/misc/lattice-ecp3-config.c
index 626fdcaf2510..8aa60907ced4 100644
--- a/drivers/misc/lattice-ecp3-config.c
+++ b/drivers/misc/lattice-ecp3-config.c
@@ -119,10 +119,8 @@ static void firmware_load(const struct firmware *fw, void *context)
dev_dbg(&spi->dev, "FPGA Status=%08x\n", status);
buffer = kzalloc(fw->size + 8, GFP_KERNEL);
- if (!buffer) {
- dev_err(&spi->dev, "Error: Can't allocate memory!\n");
+ if (!buffer)
return;
- }
/*
* Insert WRITE_INC command into stream (one SPI frame)
@@ -196,10 +194,9 @@ static int lattice_ecp3_probe(struct spi_device *spi)
int err;
data = devm_kzalloc(&spi->dev, sizeof(*data), GFP_KERNEL);
- if (!data) {
- dev_err(&spi->dev, "Memory allocation for fpga_data failed\n");
+ if (!data)
return -ENOMEM;
- }
+
spi_set_drvdata(spi, data);
init_completion(&data->fw_loaded);
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
