On Wed, 2018-01-03 at 11:28 -0800, Mahesh Bandewar (महेश बंडेवार) wrote: > On Wed, Jan 3, 2018 at 12:45 AM, SF Markus Elfring > <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote: > > > > Omit an extra message for a memory allocation failure in this function. > > > > > > > > This issue was detected by using the Coccinelle software. > > > > > > > > > > What is the issue with this message? > > > > * Is it redundant? > > > > * Would a Linux allocation failure report be already sufficient here? > > > > If you see 8 out of 9 call sites in this file ignore the return value. > This message in the log could give a clue when debugging. Unless it's > spamming it's not harmful, or is it? A failed kzalloc() would already give a complete stack trace. Really the pr_err() adds no value here. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
