From: Colin King <colin.king@xxxxxxxxxxxxx> Date: Fri, 22 Dec 2017 01:01:35 +0000 > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The function tcp_recv_timestamp is local to the source and does not > need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'tcp_recv_timestamp' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> This doesn't apply cleanly to any of my trees, please be explicit about which tree you are targetting once you fix this up, also: > @@ -1729,7 +1729,7 @@ static void tcp_update_recv_tstamps(struct sk_buff *skb, > } > > /* Similar to __sock_recv_timestamp, but does not require an skb */ > -void tcp_recv_timestamp(struct msghdr *msg, const struct sock *sk, > +static void tcp_recv_timestamp(struct msghdr *msg, const struct sock *sk, > struct scm_timestamping *tss) If you change where the openning parenthesis of a function definition occurs, you have to adjust the indentation of the second line of arguments so that it starts precisely at the first column after the openning parenthesis. Thank you. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
