On Thu, Dec 21, 2017 at 11:32:10PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Currently the return status ret is being checked but it has not been > updated since the previous check on ret. It appears that assignment of > ret from return status of the call to sdw_cdns_enable_interrupt was > accidentally ommited. Fix this. Applied, thanks > > Detected by CoverityScan, CID#1463148 ("Logically dead code") > > Fixes: 71bb8a1b059e ("soundwire: intel: Add Intel Master driver") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- > drivers/soundwire/intel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > index 6a9177ea6eb9..86a7bd1fc912 100644 > --- a/drivers/soundwire/intel.c > +++ b/drivers/soundwire/intel.c > @@ -295,7 +295,7 @@ static int intel_probe(struct platform_device *pdev) > if (ret) > goto err_init; > > - sdw_cdns_enable_interrupt(&sdw->cdns); > + ret = sdw_cdns_enable_interrupt(&sdw->cdns); > if (ret) > goto err_init; > > -- > 2.14.1 > -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html