Hi, On 12/16/2017 05:54 AM, SF Markus Elfring wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Sat, 16 Dec 2017 14:21:04 +0100 > > Replace the specification of data structures by variable references > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. After some thought, I've decided to reject this patch and others like it because I feel it will make long term maintenance of the PS3 code more difficult. Some observations: o Your patch fixes no bug nor replaces any depreciated feature. o There will be no functional change; the generated binary will be nearly identical. o The PS3 kernel support is now over 10 years old. o I need to continue support for a few old kernel versions, specifically linux-3.15 and linux-2.6.30. That includes keeping them working with new toolchain versions. I need to back port fixes to these old kernels. o When problems arise I sometimes need to use git bisect back to old kernel versions. When I do the bisect I often have fixes and local debug patches that I apply to the bisected tree before building. o Source code changes between versions causes patch conflicts that need to be manually resolved. This can be error prone and very time consuming on a long bisect session. My decision to reject this patch and others like it is in attempt to minimize the code maintenance effort. If you have patches that fix bugs, upgrade depreciated features, or generally improve functionality please submit them for review. -Geoff -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
