From: Colin Ian King <colin.king@xxxxxxxxxxxxx> The check of len being zero is redundant as it has already been sanity checked for this value at the start of the function. Hence it is impossible for this test to be true and so the redundant code can be removed. Detected by CoverityScan, CID#1462748 ("Logically dead code") Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> --- drivers/mtd/nand/nand_base.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index afd5e18db81c..9daaa23db943 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -1507,10 +1507,6 @@ static int nand_read_param_page_op(struct nand_chip *chip, u8 page, void *buf, }; struct nand_operation op = NAND_OPERATION(instrs); - /* Drop the DATA_IN instruction if len is set to 0. */ - if (!len) - op.ninstrs--; - return nand_exec_op(chip, &op); } -- 2.14.1 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html