On Fri, 2017-12-08 at 14:54 +0300, Dan Carpenter wrote:
> I get a Smatch warning here:
>
> sound/soc/intel/skylake/skl-nhlt.c:335 skl_get_ssp_clks()
> error: testing array offset 'j' after use.
>
> The code is harmless, but the checker is right that we should swap
> these
> two conditions so we verify that the offset is within bounds before we
> use it.
> - for (j = 0; (sclk[id].rate_cfg[j].rate != 0) &&
> - (j < SKL_MAX_CLK_RATES); j++) {
> + for (j = 0; (j < SKL_MAX_CLK_RATES) &&
> + (sclk[id].rate_cfg[j].rate != 0); j++) {
> if (sclk[id].rate_cfg[j].rate == rate) {
> present = true;
> break;
I would rather remove also redundant parens and move the condition into
the loop.
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
