Colin King <colin.king@xxxxxxxxxxxxx> wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The structure nf_conntrack_l4proto_gre4 is local to the source and does > not need to be in global scope, so make it static. This bug was added in commit b9679a9fd3a7d36ea3deb2864a00cc413c5aae28 netfilter: conntrack: l4 protocol trackers can be const > -struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = { > +static struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = { This should be 'static const'. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html