On Wed, 6 Dec 2017, Julia Lawall wrote: > > There's a preference in Linux to use: > > > > key_ref = ERR_PTR(-error); > > if (something) > > goto error; > > > > instead because it uses less vertical space. It might originally have been > > promulgated by Linus, but I don't remember. Though you do have a point - your > > way makes error handling less subject breakage from code rearrangement. > > I have the impression that there are many examples of both approaches. I thought this was mainly to set a default error condition once and then some call during the function sets it to zero on success. -- James Morris <james.l.morris@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
