From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> Date: Tue, 21 Nov 2017 20:46:49 +0100 > Error code returned by 'bnxt_read_sfp_module_eeprom_info()' is handled a > few lines above when reading the A0 portion of the EEPROM. > The same should be done when reading the A2 portion of the EEPROM. > > In order to correctly propagate an error, update 'rc' in this 2nd call as > well, otherwise 0 (success) is returned. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> Patch applied, thanks Chrisophe. I cannot see any legitimate reason to ignore errors returned here, as an error would mean a partial read back of the data to the caller. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html