On Fri, Nov 24, 2017 at 12:03:32PM +0000, Adam Thomson wrote: > On 23 November 2017 20:06, SF Markus Elfring wrote: > > Add a jump target so that a bit of exception handling can be better reused > > in an if branch of this function. > Hmm. Doesn't really gain an awful lot this. Would understand if there were > multiple return paths, but in that case I'd have implemented something like > this anyway. Also your patch description isn't really correct. You're re-using > code from the sunny day scenario to handle an exception. Other people have given him similar feedback on his other patches with this pattern. I'm not intending to apply any of them.
Attachment:
signature.asc
Description: PGP signature
