[bug report] perf report: Add dump_read function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Jiri Olsa,

This is a semi-automatic email about new static checker warnings.

The patch dac7f6b7ed1c: "perf report: Add dump_read function" from 
Aug 24, 2017, leads to the following Smatch complaint:

    ./tools/perf/util/session.c:1148 dump_read()
     error: we previously assumed 'evsel' could be null (see line 1145)

./tools/perf/util/session.c
  1144		printf(": %d %d %s %" PRIu64 "\n", event->read.pid, event->read.tid,
  1145		       evsel ? perf_evsel__name(evsel) : "FAIL",
                       ^^^^^
The patch adds a check for NULL

  1146		       event->read.value);
  1147	
  1148		read_format = evsel->attr.read_format;
                              ^^^^^^^
followed by an unchecked dereference.

  1149	
  1150		if (read_format & PERF_FORMAT_TOTAL_TIME_ENABLED)

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux