RE: [PATCH] IB/qib: remove redundant setting of any in for-loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > On Fri, 2017-10-20 at 09:21 +0200, Colin King wrote:
> > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> > >
> > > The variable all is being set but is never read after this
> > > hence it can be removed from the for loop initialization.
> > > Cleans up clang warning:
> >
> > any is really used as bool and is initialized at function
> > entry.  The earlier loop also reinitializes any unnecessarily.
> 
> Denny, can you weigh in on what you want in this thread?  Thanks.
> 

I am ok with both Colin's and Joe's patch.

Joe's patch would require additional testing vs. the trivial warning fix.

Then there is a "guideline"  to keep fixes separate from clean up...

Doug,  do you want a tested patch from me?

Mike

��.n��������+%������w��{.n����z�ޗ�����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux